port to Python 3 #524
port to Python 3 #524
Conversation
We dropped 2.6 support anyway.
|
Builds on #520. |
|
Currently hitting an issue with cookie handling: http://bugs.python.org/issue11315. |
|
I did a bunch of this work a while ago, but never pushed it up because I got stuck. It's on the py3 branch. |
| @@ -122,7 +119,7 @@ def hit(self, method, path='/', data=None, body=b'', content_type=MULTIPART_CONT | |||
| if content_type is MULTIPART_CONTENT: | |||
| body = encode_multipart(BOUNDARY, data) | |||
|
|
|||
| environ = self.build_wsgi_environ(method, path, body, str(content_type), **headers) | |||
| environ = self.build_wsgi_environ(method, path, body, six.binary_type(content_type), **headers) | |||
There was a problem hiding this comment.
six.binary_type is just bytes, and you shouldn't call it.
|
Closing this PR. Porting to Python 3 has proven to be a bridge too far for us: #526. 😞 |
|
I think I'd rather say that we're going to port to python 3 after we do the pending major restructuring. |
Do you think this PR is worth keeping open until then? Seems to me that the restructuring is major enough that it's not worth keeping this PR. We should start a new one. |
|
Agreed; sorry, I thought this was the issue, not the PR. |
Closes #493.