server k8s common module #2632
Merged
server k8s common module #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abvaidya
force-pushed
the
server-k8s-common
branch
2 times, most recently
from
efd4d76 to
902fd89
Compare
havetisyan
requested changes
May 30, 2024
| * @return secret for the given key and application as char[] | ||
| */ | ||
| default char[] getSecret(String appName, String keygroupName, String keyName) { | ||
| return keyName.toCharArray(); |
There was a problem hiding this comment.
this should be set to getSecret(appName, null, keyName); to main backward compatibility and not break anyone before they get a chance to update their code.
Signed-off-by: Abhijeet V <31417623+abvaidya@users.noreply.github.com>
… implementation Signed-off-by: Abhijeet V <31417623+abvaidya@users.noreply.github.com>
Signed-off-by: Abhijeet V <31417623+abvaidya@users.noreply.github.com>
abvaidya
force-pushed
the
server-k8s-common
branch
from
7c18f77 to
2872b5a
Compare
Signed-off-by: Abhijeet V <31417623+abvaidya@users.noreply.github.com>
abvaidya
force-pushed
the
server-k8s-common
branch
from
d1454d6 to
8118073
Compare
havetisyan
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution Checklist:
Attach Screenshots (Optional)