-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix caching, decode images ahead of time #229
Conversation
These commits implement the caching fix mentioned in #173 along with some miscellaneous improvements. |
Thanks @actuday6418. #173 also introduced #228, can you get that fixed as well in this PR? |
Fixes #228 |
Thanks for sending the updates. Unfortunately with the alphagen updates I think I need to test this on actual hardware to see how the keyer responds. I will not be able to do that until Friday or next Monday |
I also noticed one more problem while using the app at the tournament, #173 updated the sudden death view to be wide, but did not add the team name text back in. I have not had a chance to verify the behavior in the overtime periods. Could you fix this? |
I did some testing with the ATEM, and I don't think either the old code nor the new code you uploaded is correct. Here is a screenshot of the old code: And with the changes you made: As you can see in both images, the white transparency is far less transparent than the black, though they should be equal. The changes proposed here make the problem worse, not better. I did some research, and the ATEM is expecting a pre-multiplied key, which means we actually have to multiply the color channels by the alpha channel while processing from raw to color. I have tried changing to that, and I think the result is what we actually want: I have pushed my changes here. @actuday6418 could you make sure the pmk process also gets applied to any images that get downloaded? |
It doesn't look like #228 is resolved yet. See the video below. timeout_flags_cropped.mp4 |
Also, the rendering when the game changes isn't quite fixed. Some comments on the video below:
game_change_cropped.mp4 |
It was fixed with my change of drawing the timeout graphic underneath the team name banner graphic and drawing to the color feed without alpha. Looks like your change reintroduced the issue by adding transparency to the color feed, revealing the timeout graphics underneath. I think the best solution, if possible, would be to switch the ATEM to straight keying. We would avoid the extra image processing as well. If that cannot be done, I can try to come up with a solution like drawing only the part of the image that is on the right side of the time and state graphic. |
Unfortunately the pre-multiplied key is the only mode supported by the ATEM. Would it be simple to just draw the flag first, then draw a black box over it on the left side? (Draw all the other stuff after the black box, so that nothing gets unintentionally covered) |
This reverts commit b0d2592.
No description provided.