Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Service Warning script #1287

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Zusier
Copy link
Contributor

@Zusier Zusier commented Nov 8, 2024

Questions

Describe your pull request

Working to fulfill [FEATURE] - Initial warning on all services cmds

This pull request includes changes to add a reusable warning for scripts that modify services. The changes ensure that users are explicitly warned about potential service modifications and their implications.

Addition of Service Modification Warnings:

  • Reusable Warning Script:

    • Added a new script serviceWarning.cmd that provides a standardized warning message to users about potential service modifications and their consequences. (src/playbook/Executables/AtlasModules/Scripts/serviceWarning.cmd)
  • Integration of Warning Script:

    • Added calls to the serviceWarning.cmd script in the following service modification scripts:
      • Disable Lanman Workstation.cmd
      • Disable Network Discovery Services.cmd
      • Disable SuperFetch.cmd

I would like to discuss the scope of where we apply this warning and if we should add it to scripts that are defaults or restore functionality?

@github-actions github-actions bot added the playbook Playbook related issues/PRs label Nov 8, 2024
@Zusier Zusier changed the title Create Service Warning Create Service Warning script Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playbook Playbook related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant