Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions
Describe your pull request
Working to fulfill [FEATURE] - Initial warning on all services cmds
This pull request includes changes to add a reusable warning for scripts that modify services. The changes ensure that users are explicitly warned about potential service modifications and their implications.
Addition of Service Modification Warnings:
Reusable Warning Script:
serviceWarning.cmd
that provides a standardized warning message to users about potential service modifications and their consequences. (src/playbook/Executables/AtlasModules/Scripts/serviceWarning.cmd
)Integration of Warning Script:
serviceWarning.cmd
script in the following service modification scripts:Disable Lanman Workstation.cmd
Disable Network Discovery Services.cmd
Disable SuperFetch.cmd
I would like to discuss the scope of where we apply this warning and if we should add it to scripts that are defaults or restore functionality?