feature branch deployments #112
Conversation
| - AppClientBucket: | ||
| Fn::ImportValue: | ||
| Fn::Sub: ${pCognitoStackName}-AppClientBucket | ||
| TimeoutInMinutes: 5 |
There was a problem hiding this comment.
This seems like it belongs in the deploy component rather than base as it's only relevant to the application. Then the pAppClientDomain can be got from the existing sub_domain / hosted_zone thats already available in that component
| Value: !Sub | ||
| - lists-${ResourceName} | ||
| - ResourceName: !If [ IsDev, !Ref pCleanBranch, !Ref pEnvironment ] |
There was a problem hiding this comment.
I intentionally used the !Ref ListsSecret so the name wouldn't have to be constructed twice, it's a bit of a gotcha if the secrets name is changed, it had to be changed identically here as well. The downside is the secrets name has to parsed from the URI but i thought that was the lesser of the evils
| @@ -15,6 +15,9 @@ SLACK_DEPLOY_NOTIFICATION = true | |||
| SLACK_ALERT_CHANNEL = zabbix-lists | |||
| AUTO_DEPLOY = true | |||
|
|
|||
| COGNITO_STACK_NAME = ala-cognito-pool-external-app-clients | |||
| APP_CLIENT_DOMAIN = {PRODUCT_NAME}-${CLEAN_BRANCH}.${HOSTED_ZONE} | |||
There was a problem hiding this comment.
is this a duplicate of the app client domain used in the deploy component?
| - UserPoolId: | ||
| Fn::ImportValue: | ||
| Fn::Sub: "${pBaseStackName}-UserPoolId" | ||
|
|
There was a problem hiding this comment.
Oh cool, that looks like a good way to include imports as environment vars in the JSON. Is it possible to retain the function shortform for !Sub vs Fn::Sub at the beginning?
| @@ -8,23 +8,33 @@ REGION = ap-southeast-2 | |||
| BOOTSTRAP_STACK_NAME = ala-bedrock-cicd-bootstrap-production | |||
| BUCKETS_STACK_NAME = ala-bedrock-cicd-buckets-production | |||
| VPC_STACK_NAME = ala-bedrock-vpc-production | |||
| REGOLITH_STACK_NAME = ala-regolith-cluster-testing | |||
| REGOLITH_STACK_NAME = ala-regolith-cluster-testing-testing | |||
There was a problem hiding this comment.
there's a PR in to fix the duplication in the REGOLITH_STACK_NAME
|
Looks good Bruce. I still wonder about using the CLI to create the app clients rather than CloudFormation, it would remove the dependency of having the nested template managed in a different repo and having to keep it up to date there |
Fn::ImportValue