Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added import check from astropy for LombScargle #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LucaCerina
Copy link

I've noticed that Astropy 6.0.0 changed part of the API so now LombScargle periodogram fails to import (see https://docs.astropy.org/en/v6.0.0/changelog.html)

I've included an import check to be sure it doesn't crash.
I don't know if astropy 3.0.4 is a hard requirement, but if it's just for LombScargle it can be probably increased to the latest version.

Copy link

@alexsanjoseph alexsanjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@Saskia-K
Copy link

Saskia-K commented Mar 5, 2024

I was just about to propose the same. Thanks @LucaCerina ! Hoping this gets merged soon.

@LucaCerina
Copy link
Author

@robinchampseix what is the status of the project? Does it need helps in terms of maintenance?

@LucaBia
Copy link

LucaBia commented Apr 24, 2024

This works for me too! Thank you @LucaCerina

@masud1901
Copy link

I was about to say this.

Copy link

@MatthewKrinn1 MatthewKrinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this line, my code will not compile and actually import hrv-analysis. Because of this, I can't use it in my product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants