Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to prevent issues if chrome.storage.get unexpectedly returns undefined #1216

Merged
merged 4 commits into from
Jun 29, 2024

Conversation

mymindstorm
Copy link
Member

@mymindstorm mymindstorm commented Jun 26, 2024

Attempt to fix #1215

@mymindstorm mymindstorm requested a review from Sneezry June 26, 2024 00:58
@mymindstorm mymindstorm force-pushed the try-to-fix-undefined-issue branch from 3d37bea to ab7e15e Compare June 26, 2024 01:13
@mymindstorm
Copy link
Member Author

The CI is a problem with upstream. I've patched as a stopgap until mujo-code/puppeteer-headful#134 gets merged. After this is merged, #1214 should also pass.

@Sneezry
Copy link
Member

Sneezry commented Jun 26, 2024

Is this a Chrome issue? chrome.storage.get should never return null or undefined. If it unexpectedly does, it could affect the account data. Is my understanding correct?

@mymindstorm
Copy link
Member Author

mymindstorm commented Jun 26, 2024 via email

@Sneezry
Copy link
Member

Sneezry commented Jun 26, 2024

Let's merge this PR first, and then continue exploring whether the unexpected results from reading the storage have any security impact on the account data.

@mymindstorm mymindstorm merged commit 6f2c492 into dev Jun 29, 2024
10 checks passed
@mymindstorm mymindstorm deleted the try-to-fix-undefined-issue branch June 29, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in chrome on v7
2 participants