Wrap lists + remove nested divs #78
Conversation
|
Maybe something to come back to after undo is merged |
|
Can we (or I) add "strip cite from links" to this, and maybe prioritize this? That bug in particular is pretty urgent |
|
Not really sure on the stability of these, nested divs in particular was pretty fiddly. Mainly did it to test out the feasibility of extending this code with new rules. Maybe just open a new PR that strips citations and see if we can merge that? |
|
sounds good |
bananaoomarang
changed the title
source/Node.js
Outdated
| return true | ||
| } | ||
|
|
||
| return isParentedBy(node.parentNode, parents) |
There was a problem hiding this comment.
Naming OCD guy here - the moment you start going up the tree, that's an ancestor rather than a parent. I know jquery has taken liberties with using parent, but it's really clear in commonplace English... hasAncestor is a decently clearer name for example.
|
List stuff seems to work pretty well. Div stuff definitely works but we possibly want to scope it better to certain situations/do something nicer there. The alternative approach would be to separate them out rather than condense them into their parent. In my testing they both look kind of weird from a user standpoint. |
Not sure on how we might want to remove nested divs. Was just messing around with this and it seems to work.
I also tried 'bubbling' them up the tree until they were no longer 'nested', but that felt worse than just unwrapping them.