Skip to content

Commit

Permalink
eslint: Enable more lints from @wordpress/eslint-plugin (#39000)
Browse files Browse the repository at this point in the history
- no-alert: Enabled for new instances. Existing instances are ignored,
  some with todo comments.
- no-bitwise: Most existing instances were intentional. Replaced one
  `| 0` with `Math.floor()`.
- no-fallthrough: One error detected and fixed. Added fall-through
  comments to the rest.
- no-useless-computed-key: Auto-fixed them all.
- no-useless-return: Auto-fixed, then had to clean up some places where
  it left empty blocks or otherwise exposed weird code flows.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10508553954

Upstream-Ref: Automattic/jetpack@befb138
  • Loading branch information
anomiex authored and matticbot committed Aug 22, 2024
1 parent c549a70 commit 041e45c
Show file tree
Hide file tree
Showing 4 changed files with 86 additions and 88 deletions.
58 changes: 29 additions & 29 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,7 @@ export const liveResizeModifier: liveResizeModifierFactory = (
name: 'liveResizeModifier',
enabled: true,
phase: 'main',
fn: () => {
return;
},
fn: () => {},
effect: arg0 => {
try {
const { state, instance } = arg0 as ModifierArgumentsWithObserversProp; // augment types here because we are mutating the properties on the argument that is passed in
Expand Down
Loading

0 comments on commit 041e45c

Please sign in to comment.