Skip to content

Commit

Permalink
Launchpad: Add the "from" param to the Customize Domain task (#33404)
Browse files Browse the repository at this point in the history
* Adds the from parameter to the Domain Customize task

* Changelog

---------

Co-authored-by: Valter Lorran <valter.lorran@automattic.com>

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/6382787931
  • Loading branch information
valterlorran authored and matticbot committed Oct 2, 2023
1 parent c1f2835 commit dc54488
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 11 deletions.
8 changes: 4 additions & 4 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions vendor/automattic/jetpack-mu-wpcom/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ This is an alpha version! The changes listed here are not final.
### Added
- Add new task for user to confirm email when purchasing a domain.
- Add plugin to show frontend email nag for domains with unverified email address
- Adds a URL param to identify the source of the navigation on the Customize domain task.

## [4.12.0] - 2023-09-28
### Added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,11 @@ function wpcom_launchpad_get_task_definitions() {
'is_complete_callback' => 'wpcom_launchpad_is_domain_customize_completed',
'is_visible_callback' => 'wpcom_launchpad_is_domain_customize_task_visible',
'get_calypso_path' => function ( $task, $default, $data ) {
return '/domains/add/' . $data['site_slug_encoded'];
// The from parameter is used to redirect the user back to the Launchpad when they
// click on the Back button on the domain customization page.
// TODO: This can cause problem if this task is used in the future for other flows
// that are not in the Customer Home page. We should find a better way to handle this.
return '/domains/add/' . $data['site_slug_encoded'] . '?from=my-home';
},
),

Expand Down
6 changes: 3 additions & 3 deletions vendor/composer/installed.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
"packages": [
{
"name": "automattic/jetpack-mu-wpcom",
"version": "4.13.0-alpha.1696226389",
"version_normalized": "4.13.0.0-alpha1696226389",
"version": "4.13.0-alpha.1696263755",
"version_normalized": "4.13.0.0-alpha1696263755",
"dist": {
"type": "path",
"url": "/tmp/jetpack-build/Automattic/jetpack-mu-wpcom",
"reference": "88468d6961398295e57e3e4126c395e478d17c65"
"reference": "f4cee7b2520cf804ba8fee8415466cb59699fedb"
},
"require-dev": {
"automattic/jetpack-changelogger": "^3.3.11",
Expand Down
6 changes: 3 additions & 3 deletions vendor/composer/installed.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
),
'versions' => array(
'automattic/jetpack-mu-wpcom' => array(
'pretty_version' => '4.13.0-alpha.1696226389',
'version' => '4.13.0.0-alpha1696226389',
'reference' => '88468d6961398295e57e3e4126c395e478d17c65',
'pretty_version' => '4.13.0-alpha.1696263755',
'version' => '4.13.0.0-alpha1696263755',
'reference' => 'f4cee7b2520cf804ba8fee8415466cb59699fedb',
'type' => 'jetpack-library',
'install_path' => __DIR__ . '/../automattic/jetpack-mu-wpcom',
'aliases' => array(),
Expand Down

0 comments on commit dc54488

Please sign in to comment.