eslint: Remove jsx-a11y/label-has-associated-control override (#39736)

`@wordpress/eslint-plugin` sets `jsx-a11y/label-has-associated-control`
to "htmlFor", while we had it overridden to "either". Turns out there
was only place that wasn't already doing "htmlFor", so let's fix that
one place and go for it.

This also removes `jsx-a11y/label-has-for` which is deprecated in favor
of `jsx-a11y/label-has-associated-control`. The former config was
equivalent to "either".

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/11281457159

Upstream-Ref: Automattic/jetpack@89f5928

vendor/automattic/jetpack-mu-wpcom/src/features/wpcom-block-editor-nux/src/recommended-tags-modal/form-label.tsx

@@ -21,7 +21,7 @@ const FormLabel: FunctionComponent< Props & LabelProps > = ( {
 	const hasChildren: boolean = Children.count( children ) > 0;
 
 	return (
-		// eslint-disable-next-line jsx-a11y/label-has-for
+		// eslint-disable-next-line jsx-a11y/label-has-associated-control
 		<label { ...labelProps } className={ clsx( className, 'form-label' ) }>
 			{ children }
 			{ hasChildren && required && (