Skip to content

Commit

Permalink
webpack-config: Default to 'source-map' in dev mode (#33924)
Browse files Browse the repository at this point in the history
It seems our developers have spoken: 25 webpack configs in the monorepo
have been setting webpack's `devtool` to 'source-map' for development
builds, while only 8 have used the default from webpack-config (and 2
are explicitly setting no devtool).

So let's change the default to 'source-map' so everything can be working
the same way.

Note this doesn't change anything for production builds, this is only
for development.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/6730930552
  • Loading branch information
anomiex authored and matticbot committed Nov 2, 2023
1 parent bb6c0e5 commit f2fc9ea
Show file tree
Hide file tree
Showing 22 changed files with 184 additions and 159 deletions.
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
"automattic/jetpack-composer-plugin": "^1.1.14",
"automattic/jetpack-config": "^1.15.4",
"automattic/jetpack-connection": "^1.58.2",
"automattic/jetpack-identity-crisis": "^0.11.1",
"automattic/jetpack-my-jetpack": "^3.11.0",
"automattic/jetpack-search": "^0.39.4",
"automattic/jetpack-identity-crisis": "^0.11.2-alpha",
"automattic/jetpack-my-jetpack": "^3.11.1-alpha",
"automattic/jetpack-search": "^0.39.5-alpha",
"automattic/jetpack-stats": "^0.6.6",
"automattic/jetpack-status": "^1.18.5",
"automattic/jetpack-sync": "^1.60.1",
Expand Down
5 changes: 5 additions & 0 deletions jetpack_vendor/automattic/jetpack-assets/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.18.14-alpha] - unreleased

This is an alpha version! The changes listed here are not final.

## [1.18.13] - 2023-10-19
### Changed
- Updated package dependencies. [#33687]
Expand Down Expand Up @@ -372,6 +376,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Statically access asset tools

[1.18.14-alpha]: https://github.com/Automattic/jetpack-assets/compare/v1.18.13...v1.18.14-alpha
[1.18.13]: https://github.com/Automattic/jetpack-assets/compare/v1.18.12...v1.18.13
[1.18.12]: https://github.com/Automattic/jetpack-assets/compare/v1.18.11...v1.18.12
[1.18.11]: https://github.com/Automattic/jetpack-assets/compare/v1.18.10...v1.18.11
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.11.2-alpha] - unreleased

This is an alpha version! The changes listed here are not final.

## [0.11.1] - 2023-10-19
### Changed
- Updated package dependencies. [#33687]
Expand Down Expand Up @@ -435,6 +439,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Updated package dependencies.
- Use Connection/Urls for home_url and site_url functions migrated from Sync.

[0.11.2-alpha]: https://github.com/Automattic/jetpack-identity-crisis/compare/v0.11.1...v0.11.2-alpha
[0.11.1]: https://github.com/Automattic/jetpack-identity-crisis/compare/v0.11.0...v0.11.1
[0.11.0]: https://github.com/Automattic/jetpack-identity-crisis/compare/v0.10.7...v0.11.0
[0.10.7]: https://github.com/Automattic/jetpack-identity-crisis/compare/v0.10.6...v0.10.7
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"automattic/jetpack-constants": "^1.6.23",
"automattic/jetpack-status": "^1.18.5",
"automattic/jetpack-logo": "^1.6.3",
"automattic/jetpack-assets": "^1.18.13"
"automattic/jetpack-assets": "^1.18.14-alpha"
},
"require-dev": {
"automattic/jetpack-changelogger": "^3.3.11",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Identity_Crisis {
/**
* Package Version
*/
const PACKAGE_VERSION = '0.11.1';
const PACKAGE_VERSION = '0.11.2-alpha';

/**
* Instance of the object.
Expand Down
5 changes: 5 additions & 0 deletions jetpack_vendor/automattic/jetpack-jitm/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.5.2-alpha] - unreleased

This is an alpha version! The changes listed here are not final.

## [2.5.1] - 2023-10-19
### Changed
- Updated package dependencies. [#33687]
Expand Down Expand Up @@ -641,6 +645,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Update Jetpack to use new JITM package

[2.5.2-alpha]: https://github.com/Automattic/jetpack-jitm/compare/v2.5.1...v2.5.2-alpha
[2.5.1]: https://github.com/Automattic/jetpack-jitm/compare/v2.5.0...v2.5.1
[2.5.0]: https://github.com/Automattic/jetpack-jitm/compare/v2.4.0...v2.5.0
[2.4.0]: https://github.com/Automattic/jetpack-jitm/compare/v2.3.19...v2.4.0
Expand Down
2 changes: 1 addition & 1 deletion jetpack_vendor/automattic/jetpack-jitm/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "GPL-2.0-or-later",
"require": {
"automattic/jetpack-a8c-mc-stats": "^1.4.22",
"automattic/jetpack-assets": "^1.18.13",
"automattic/jetpack-assets": "^1.18.14-alpha",
"automattic/jetpack-connection": "^1.58.2",
"automattic/jetpack-device-detection": "^1.4.27",
"automattic/jetpack-logo": "^1.6.3",
Expand Down
2 changes: 1 addition & 1 deletion jetpack_vendor/automattic/jetpack-jitm/src/class-jitm.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
*/
class JITM {

const PACKAGE_VERSION = '2.5.1';
const PACKAGE_VERSION = '2.5.2-alpha';

/**
* The configuration method that is called from the jetpack-config package.
Expand Down
5 changes: 5 additions & 0 deletions jetpack_vendor/automattic/jetpack-my-jetpack/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.11.1-alpha] - unreleased

This is an alpha version! The changes listed here are not final.

## [3.11.0] - 2023-10-30
### Added
- Add site data to unpurchased state of VaultPress Backup card to My Jetpack. [#33607]
Expand Down Expand Up @@ -1083,6 +1087,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Created package

[3.11.1-alpha]: https://github.com/Automattic/jetpack-my-jetpack/compare/3.11.0...3.11.1-alpha
[3.11.0]: https://github.com/Automattic/jetpack-my-jetpack/compare/3.10.0...3.11.0
[3.10.0]: https://github.com/Automattic/jetpack-my-jetpack/compare/3.9.1...3.10.0
[3.9.1]: https://github.com/Automattic/jetpack-my-jetpack/compare/3.9.0...3.9.1
Expand Down
4 changes: 2 additions & 2 deletions jetpack_vendor/automattic/jetpack-my-jetpack/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
"license": "GPL-2.0-or-later",
"require": {
"automattic/jetpack-admin-ui": "^0.2.24",
"automattic/jetpack-assets": "^1.18.13",
"automattic/jetpack-assets": "^1.18.14-alpha",
"automattic/jetpack-connection": "^1.58.2",
"automattic/jetpack-jitm": "^2.5.1",
"automattic/jetpack-jitm": "^2.5.2-alpha",
"automattic/jetpack-licensing": "^1.8.4",
"automattic/jetpack-plugins-installer": "^0.2.5",
"automattic/jetpack-redirect": "^1.7.27",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class Initializer {
*
* @var string
*/
const PACKAGE_VERSION = '3.11.0';
const PACKAGE_VERSION = '3.11.1-alpha';

/**
* HTML container ID for the IDC screen on My Jetpack page.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = [
index: './_inc/admin.jsx',
},
mode: jetpackWebpackConfig.mode,
devtool: jetpackWebpackConfig.isDevelopment ? 'source-map' : false,
devtool: jetpackWebpackConfig.devtool,
output: {
...jetpackWebpackConfig.output,
path: path.resolve( './build' ),
Expand Down
5 changes: 5 additions & 0 deletions jetpack_vendor/automattic/jetpack-search/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.39.5-alpha] - unreleased

This is an alpha version! The changes listed here are not final.

## [0.39.4] - 2023-10-30
### Changed
- Instant Search: rely on browsers' native lazy loading functionality when we want to lazy load images. [#33817]
Expand Down Expand Up @@ -830,6 +834,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Updated package dependencies.
- Update PHPUnit configs to include just what needs coverage rather than include everything then try to exclude stuff that doesn't.

[0.39.5-alpha]: https://github.com/Automattic/jetpack-search/compare/v0.39.4...v0.39.5-alpha
[0.39.4]: https://github.com/Automattic/jetpack-search/compare/v0.39.3...v0.39.4
[0.39.3]: https://github.com/Automattic/jetpack-search/compare/v0.39.2...v0.39.3
[0.39.2]: https://github.com/Automattic/jetpack-search/compare/v0.39.1...v0.39.2
Expand Down
4 changes: 2 additions & 2 deletions jetpack_vendor/automattic/jetpack-search/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
"license": "GPL-2.0-or-later",
"require": {
"automattic/jetpack-connection": "^1.58.2",
"automattic/jetpack-assets": "^1.18.13",
"automattic/jetpack-assets": "^1.18.14-alpha",
"automattic/jetpack-constants": "^1.6.23",
"automattic/jetpack-status": "^1.18.5",
"automattic/jetpack-config": "^1.15.4",
"automattic/jetpack-my-jetpack": "^3.11.0"
"automattic/jetpack-my-jetpack": "^3.11.1-alpha"
},
"require-dev": {
"automattic/jetpack-changelogger": "^3.3.11",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* Search package general information
*/
class Package {
const VERSION = '0.39.4';
const VERSION = '0.39.5-alpha';
const SLUG = 'search';

/**
Expand Down
2 changes: 1 addition & 1 deletion jetpack_vendor/automattic/jetpack-stats/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "jetpack-library",
"license": "GPL-2.0-or-later",
"require": {
"automattic/jetpack-assets": "^1.18.13",
"automattic/jetpack-assets": "^1.18.14-alpha",
"automattic/jetpack-connection": "^1.58.2",
"automattic/jetpack-constants": "^1.6.23",
"automattic/jetpack-status": "^1.18.5"
Expand Down
2 changes: 1 addition & 1 deletion jetpack_vendor/automattic/jetpack-sync/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"require": {
"automattic/jetpack-connection": "^1.58.2",
"automattic/jetpack-constants": "^1.6.23",
"automattic/jetpack-identity-crisis": "^0.11.1",
"automattic/jetpack-identity-crisis": "^0.11.2-alpha",
"automattic/jetpack-password-checker": "^0.2.14",
"automattic/jetpack-ip": "^0.1.6",
"automattic/jetpack-roles": "^1.4.25",
Expand Down
10 changes: 5 additions & 5 deletions jetpack_vendor/i18n-map.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
),
'jetpack-assets' => array(
'path' => 'jetpack_vendor/automattic/jetpack-assets',
'ver' => '1.18.13',
'ver' => '1.18.14-alpha1698918897',
),
'jetpack-config' => array(
'path' => 'jetpack_vendor/automattic/jetpack-config',
Expand All @@ -22,23 +22,23 @@
),
'jetpack-idc' => array(
'path' => 'jetpack_vendor/automattic/jetpack-identity-crisis',
'ver' => '0.11.1',
'ver' => '0.11.2-alpha1698918897',
),
'jetpack-ip' => array(
'path' => 'jetpack_vendor/automattic/jetpack-ip',
'ver' => '0.1.6',
),
'jetpack-jitm' => array(
'path' => 'jetpack_vendor/automattic/jetpack-jitm',
'ver' => '2.5.1',
'ver' => '2.5.2-alpha1698918897',
),
'jetpack-licensing' => array(
'path' => 'jetpack_vendor/automattic/jetpack-licensing',
'ver' => '1.8.4',
),
'jetpack-my-jetpack' => array(
'path' => 'jetpack_vendor/automattic/jetpack-my-jetpack',
'ver' => '3.11.0',
'ver' => '3.11.1-alpha1698918897',
),
'jetpack-password-checker' => array(
'path' => 'jetpack_vendor/automattic/jetpack-password-checker',
Expand All @@ -50,7 +50,7 @@
),
'jetpack-search-pkg' => array(
'path' => 'jetpack_vendor/automattic/jetpack-search',
'ver' => '0.39.4',
'ver' => '0.39.5-alpha1698918897',
),
'jetpack-stats' => array(
'path' => 'jetpack_vendor/automattic/jetpack-stats',
Expand Down
Loading

0 comments on commit f2fc9ea

Please sign in to comment.