Update dependency commander to v13 (#40828)

* Update dependency commander to v13 * Allow undocumented args for now * Add comment about why we don't document arguments at the moment --------- Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: tbradsha <32492176+tbradsha@users.noreply.github.com>
Automattic · Jan 2, 2025 · 50d9df0 · 50d9df0
1 parent 4fe90fa
commit 50d9df0
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 9 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/projects/js-packages/eslint-changed/changelog/renovate-commander-13.x b/projects/js-packages/eslint-changed/changelog/renovate-commander-13.x
@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Updated package dependencies.
diff --git a/projects/js-packages/eslint-changed/package.json b/projects/js-packages/eslint-changed/package.json
@@ -23,7 +23,7 @@
 	},
 	"dependencies": {
 		"chalk": "5.4.1",
-		"commander": "9.3.0",
+		"commander": "13.0.0",
 		"parse-diff": "0.8.1"
 	},
 	"devDependencies": {

diff --git a/projects/js-packages/eslint-changed/src/cli.js b/projects/js-packages/eslint-changed/src/cli.js
@@ -71,9 +71,14 @@ export function createProgram( process = global.process ) {
 			'Only include messages on lines changed in the diff. This may miss things like deleting a `var` that leads to a new `no-undef` elsewhere.'
 		)
 		.option( '--format <name>', 'ESLint format to use for output.', 'stylish' )
+		// If we uncomment this line, `program` becomes a simple object when passed to main() rather than a `Command` object.
+		// .argument( '[filenames...]', 'Specified filenames to check.' )
 		.version( APP_VERSION )
 		.action( main.bind( program, process ) );
 
+	// We should document the optional extra args with `program.argument()` but this doesn't seem to work (see above).
+	program.allowExcessArguments();
+
 	return program;
 }