-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic title attribute for markdown footnotes #27388
base: trunk
Are you sure you want to change the base?
Conversation
Fixes Automattic#27387 Quick conformance test: ``` Lorem ipsum dolor sit amet[^latin]. These footnotes support Markdown[^md] and HTML[^html]. They don't choke on entities[^ent]! And quote marks are fine[^q]. What about very long footnotes[^long]? Fully multilingual[^zh] and Unicode[^🥰] compatible. [^latin]: Other Latin texts are available [^md]: Some Markdown *emphasis* and a [link](https://example.com) [^html]: Using <em>HTML</em> [^ent]: Entity support & or &? < or < [^q]: " [^long]: Sensors indicate no shuttle or other ships in this sector. According to coordinates, we have travelled 7,000 light years and are located near the system J-25. Tractor beam released, sir. Force field maintaining our hull integrity. Damage report? Sections 27, 28 and 29 on decks four, five and six destroyed. Without our shields, at this range it is probable a photon detonation could destroy the Enterprise. [^zh]: 威廉 莎士比亚 [^🥰]: 🥰 ```
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Jetpack plugin:
|
Related discussion: michelf/php-markdown#387 |
I like the idea, but let's see what comes out of the upstream discussion. I see several good points raised there. |
Fixes #27387
Quick conformance test:
Fixes #27387
Changes proposed in this Pull Request:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Write a Markdown post with the following text:
Publish the post and place your cursor over the footnote links.