Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: support features as recommendations #40492

Draft
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

IanRamosC
Copy link
Contributor

@IanRamosC IanRamosC commented Dec 6, 2024

Proposed changes:

  • This PR adds the skeleton for three features that will be available as modules in the recommendations on My Jetpack. All classes follow the same structure and we added a new get_feature_status method to the base class that will be used to override the return of get_status. This decision was made to simplify how we use the same class for different types of products/modules.
    NOTE: the changes in this PR do not affect the current behavior/functionality. This PR was created mostly to simplify reviews.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pbNhbs-bvL-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Spin up a JN site with Jetpack Beta pointing to this branch and enable sandbox access
  • Click to activate Jetpack with one click
  • Open the network tab in the console and filter by "recommendation"
  • In the survey, click on "Grow my Audience" and submit the survey
  • Confirm that the response of the request does not include any slug starting with feature_
  • Now go to /wp-admin/options-general.php?page=companion_settings and update JETPACK__SANDBOX_DOMAIN to your sandbox domain.
  • In your sandbox, checkout the branch arcpatch-D168603
  • Go back to My Jetpack, click on the three dots at the top right and then "Redo" the recommendations. Click again on "Grow my audience" and watch the network requests
  • Now, you should see feature_related-posts and feature_newsletter in the response

@IanRamosC IanRamosC self-assigned this Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/feature-recommendations branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/feature-recommendations
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@IanRamosC IanRamosC force-pushed the add/feature-recommendations branch 2 times, most recently from 2d2d973 to f2ef456 Compare December 16, 2024 14:51
@IanRamosC IanRamosC force-pushed the add/feature-recommendations branch from f2ef456 to 8de591d Compare December 16, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant