-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: support features as recommendations #40492
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
2d2d973
to
f2ef456
Compare
f2ef456
to
8de591d
Compare
Proposed changes:
get_feature_status
method to the base class that will be used to override the return ofget_status
. This decision was made to simplify how we use the same class for different types of products/modules.NOTE: the changes in this PR do not affect the current behavior/functionality. This PR was created mostly to simplify reviews.
Other information:
Jetpack product discussion
pbNhbs-bvL-p2
Does this pull request change what data or activity we track or use?
Testing instructions:
feature_
/wp-admin/options-general.php?page=companion_settings
and updateJETPACK__SANDBOX_DOMAIN
to your sandbox domain.arcpatch-D168603
feature_related-posts
andfeature_newsletter
in the response