Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate views: Hide "View" switcher #40595

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Dec 12, 2024

Fixes Automattic/wp-calypso#97395

Proposed changes:

Hides the "View" switcher on any WP Admin screen that is enforced because of the remove duplicate views experiment.

Before After
Screenshot 2024-12-12 at 11 27 54 Screenshot 2024-12-12 at 14 54 51

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Go to the placeholder experiment page: 22124-explat-experiment
  • Assign yourself to the treatment variation using the bookmarklets
  • Visit any of the screens that are currently enforcing the WP Admin view:
    • Posts > All Posts
    • Posts > Tags
    • Posts > Categories
    • Portfolio > All Projects
    • Testimonials > All Testimonials
  • Make sure the "View" switcher is not visible

@mmtr mmtr requested a review from a team December 12, 2024 13:59
@mmtr mmtr self-assigned this Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/hide-switcher-duplicated-views branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/hide-switcher-duplicated-views
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Package] Masterbar labels Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 12, 2024
Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure I must be doing something wrong, but I'm sandboxed, I've used the jetpack downloader switcher, I've used the dummy experiment bookmarklet and I'm still seeing the view switcher.

So far as I can tell, this function isn't being ran from the All Posts or Posts → Categories 🤔

@mmtr
Copy link
Member Author

mmtr commented Dec 12, 2024

I've used the jetpack downloader switcher

Have you updated you sandbox with git pull before doing this? Jetpack downloader updates the current sun/moon directory according to upstream trunk, so maybe your local trunk still points to the wrong sun/moon dir.

dsas
dsas previously approved these changes Dec 12, 2024
Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it's working now 👍

I see the View menu on e.g. Pages, but not on Posts.

@mmtr mmtr added [Type] Task and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Package] Masterbar labels Dec 13, 2024
Copy link
Contributor

@BogdanUngureanu BogdanUngureanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on both AT and Simple. Great work! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate views: Hide "View" switcher
3 participants