-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate views: Hide "View" switcher #40595
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure I must be doing something wrong, but I'm sandboxed, I've used the jetpack downloader switcher, I've used the dummy experiment bookmarklet and I'm still seeing the view switcher.
So far as I can tell, this function isn't being ran from the All Posts or Posts → Categories 🤔
Have you updated you sandbox with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it's working now 👍
I see the View menu on e.g. Pages, but not on Posts.
projects/packages/masterbar/src/admin-menu/class-base-admin-menu.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected on both AT and Simple. Great work! 🚢
Fixes Automattic/wp-calypso#97395
Proposed changes:
Hides the "View" switcher on any WP Admin screen that is enforced because of the remove duplicate views experiment.
Other information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions:
treatment
variation using the bookmarklets