-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect Meets Core: Home Page Scan Report Data Adjustments #40616
Conversation
63b1302
to
7512c64
Compare
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
b5e1222
to
8d3ff2a
Compare
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
8d3ff2a
to
72df33f
Compare
@@ -216,7 +216,10 @@ export default function ScanReport( { dataSource, data, onChangeSelection } ): J | |||
* | |||
* @see https://developer.wordpress.org/block-editor/reference-guides/packages/packages-dataviews/#getitemid-function | |||
*/ | |||
const getItemId = useCallback( ( item: ScanReportExtension ) => item.id.toString(), [] ); | |||
const getItemId = useCallback( | |||
( item: ScanReportExtension ) => `${ item.type }_${ item.slug }_${ item.version }`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we certain every item will have a type, slug and version? IIRC the slug
for core
is null
and we don't currently appear to be supply a slug
or version
property for the files object we pass. Storybook runs fine so it doesn't really appear to matter, perhaps wordpress_null_6.7.1
or files_null_null
is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps wordpress_null_6.7.1 or files_null_null is fine.
This was/is my thought, as the generated IDs are still unique, specific to the item, and accurate.
a877b8c
to
69a281a
Compare
7019369
to
d16a2a6
Compare
Proposed changes:
name
property to the files item.getItemId
method from theScanReport
component to compute item IDs based on type, slug, and version to ensure unique IDs without additional data mapping.Other information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions: