Fix/connection status inconsistencies

[CodeyGuyDylan]

Proposed changes:

The main purpose of this PR is to unify the connections states and flows in My Jetpack. It should now follow these rules

• If the site is not connected, all "Connection" CTAs should connect the site only, and then redirect users to the pricing page
• If the site is connected, but the user is not, it sends the user to the connection page, then to user connection, and back to My Jetpack, skipping the pricing page

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

GH: 3687b-pb/

Does this pull request change what data or activity we track or use?

Yes, there is going to be new events

• jetpack_myjetpack_product_card_fix_site_connection_click
• jetpack_myjetpack_product_card_fix_site_connection_success
  For when a user connects their site via a product card

Testing instructions:

1. Checkout this branch via the Jetpack Beta plugin or your local dev environment

2. Go to /wp-admin/admin.php?page=my-jetpack and scroll down to the bottom

3. Select Connect your site with one click. Ensure you are scrolled to the top of the page and that after connection, you are directed to the pricing page

site-connection.mov

5. Disconnect your site and ensure you see a few product cards with the Connect CTA
   

6. Select Connect and ensure a similar experience to the footer happens where you are connected, brought to the pricing page, and then back to My Jetpack
   

7. Scroll down to the bottom again and select Sign In in the connection footer. On the Connection page, select Connect your user account
   

8. Ensure you are led to the user connection flow, and after connecting, you go straight back to the plugin instead of the pricing page

9. Purchase a Jetpack Security plan for your site however you'd like (I used the Store Admin)

10. Go back to My Jetpack and disconnect your site

11. Confirm you see the site connection notice instead of the welcome banner

12. Scroll down to the connection footer and select Connect

13. Ensure you have a similar experience where the screen scrolls to the top and connects the site, then directs to the pricing page

14. Go back to My Jetpack and confirm you see the User connection banner now

15. Connect your user account any way you'd like (Connect footer, Connection banner, or product card) and ensure the connect flow skips the pricing page

Note: There are other ways to connect I didn't explicitly cover (Such as user connection from the Activate a license link), feel free to try out any connection flow you can think of to ensure all site connections and user connections act exactly the same.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/connection-status-inconsistencies branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/connection-status-inconsistencies
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2