fix(salesforce): handle woocommerce inactive #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adekbadek
added
the
[Status] Needs Review
and does it Fatal error? Do we need a check to see if function exists? |
|
Good idea, added in 47dab4a |
leogermani
approved these changes
Nov 8, 2024
github-actions
bot
added
[Status] Approved
|
Hey @, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to it to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Nov 15, 2024
# [5.8.0-alpha.1](v5.7.0...v5.8.0-alpha.1) (2024-11-15) ### Bug Fixes * **reader-registration-block:** fix styles of newsletter lists ([1e1d7a4](1e1d7a4)) * **salesforce:** handle woocommerce inactive ([#3521](#3521)) ([bf868a4](bf868a4)) * use user email for esp sync purposes ([#3520](#3520)) ([d6925ff](d6925ff)) * **wc-memberships:** WC for Teams join-team link; team in my-account ([#3540](#3540)) ([489ce0f](489ce0f)) ### Features * also trigger subscription change events on switch ([#3514](#3514)) ([5a84949](5a84949)) * **pwa:** enable SW file caching ([82af7d4](82af7d4)) * **starter-content:** e2e improvements; removal CLI command ([35431ac](35431ac)) * update Stripe Settings dashboard UI ([#3488](#3488)) ([7974fac](7974fac)) * **wc-memberships:** support team data in import ([63c78b2](63c78b2))
|
🎉 This PR is included in version 5.8.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Nov 25, 2024
# [5.8.0](v5.7.0...v5.8.0) (2024-11-25) ### Bug Fixes * **reader-registration-block:** fix styles of newsletter lists ([1e1d7a4](1e1d7a4)) * **salesforce:** handle woocommerce inactive ([#3521](#3521)) ([bf868a4](bf868a4)) * use user email for esp sync purposes ([#3520](#3520)) ([d6925ff](d6925ff)) * **wc-memberships:** WC for Teams join-team link; team in my-account ([#3540](#3540)) ([489ce0f](489ce0f)) ### Features * also trigger subscription change events on switch ([#3514](#3514)) ([5a84949](5a84949)) * **pwa:** enable SW file caching ([82af7d4](82af7d4)) * **starter-content:** e2e improvements; removal CLI command ([35431ac](35431ac)) * update Stripe Settings dashboard UI ([#3488](#3488)) ([7974fac](7974fac)) * **wc-memberships:** support team data in import ([63c78b2](63c78b2))
|
🎉 This PR is included in version 5.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
If WC is inactive, the
wc_*functions will be interpreted as namespaced (Newspack\wc_*). This plugin avoids that.How to test the changes in this Pull Request:
Smoke test!
Other information: