Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update string filter usage #3575

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Update string filter usage #3575

merged 1 commit into from
Nov 26, 2024

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Updates FILTER_SANITIZE_STRING to FILTER_SANITIZE_FULL_SPECIAL_CHARS. The former is deprecated.

Similar to Automattic/newspack-ads#755

How to test the changes in this Pull Request:

Smoke test, should not result in any noticeable changes besides lack of a PHP Warning.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 25, 2024
@adekbadek adekbadek requested a review from a team as a code owner November 25, 2024 10:55
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Aside: is there any way to enable/disable the Media Partners extension outside of calling Newspack\Settings::activate_optional_module( 'media-partners' ) via CLI?

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 25, 2024
@adekbadek
Copy link
Member Author

Nope, there's no UI for this.

@adekbadek adekbadek merged commit 156c0c5 into trunk Nov 26, 2024
9 checks passed
@adekbadek adekbadek deleted the chore/filter-string branch November 26, 2024 10:00
Copy link

Hey @adekbadek, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.9.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants