-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update string filter usage #3575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Aside: is there any way to enable/disable the Media Partners extension outside of calling Newspack\Settings::activate_optional_module( 'media-partners' )
via CLI?
Nope, there's no UI for this. |
Hey @adekbadek, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
🎉 This PR is included in version 5.9.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Updates
FILTER_SANITIZE_STRING
toFILTER_SANITIZE_FULL_SPECIAL_CHARS
. The former is deprecated.Similar to Automattic/newspack-ads#755
How to test the changes in this Pull Request:
Smoke test, should not result in any noticeable changes besides lack of a PHP Warning.
Other information: