Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont load textdomain too early #3629

Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix: dont load textdomain too early #3629

merged 3 commits into from
Dec 16, 2024

Conversation

leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Fixes early call to load_plugin_textdomain

How to test the changes in this Pull Request:

  1. Smoke test
  2. Test if translations are loaded

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 13, 2024
@leogermani leogermani self-assigned this Dec 13, 2024
@leogermani leogermani requested a review from a team as a code owner December 13, 2024 18:38
laurelfulford
laurelfulford requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Newspack Plugin doesn't bundle translations, but when I try to add my own, they don't seem to work with this branch but they do work on trunk. This is what I did:

  1. Created a .po and .mo file for Spanish, and translated one string ("Sign in with Google"
  2. Switched the site to use Spanish.
  3. On trunk, clicked the Sign In button to check the Sign in with Google button I "translated":

CleanShot 2024-12-13 at 12 46 07

  1. Switched to this branch and reopened the modal:

CleanShot 2024-12-13 at 12 46 47

Nothing stands out as incorrect about how you've done this though 😕

@dkoo
Copy link
Contributor

dkoo commented Dec 13, 2024 •
edited
Loading

I'm seeing the same thing as @laurelfulford. On this branch, "translated" strings don't get shown 😕

EDIT: Not sure if it's just because of my local environment, but 123daf9 fixes it for me

@laurelfulford laurelfulford self-requested a review December 13, 2024 23:24
laurelfulford
laurelfulford approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123daf9 also fixes it for me (thanks @dkoo!): confirmed my terrible translation file is loading, and that the PHP Notices go away in the terminal with this plugin.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 13, 2024
@dkoo dkoo mentioned this pull request Dec 13, 2024
Merged
@leogermani leogermani merged commit 76c1f97 into trunk Dec 16, 2024
8 checks passed
@leogermani leogermani deleted the fix/load-textdomain branch December 16, 2024 13:00
@github-actions GitHub Actions
Copy link

Hey @leogermani, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Dec 16, 2024
@semantic-release-bot
chore(release): 5.10.0-alpha.2 [skip ci]
6106edf 
# [5.10.0-alpha.2](v5.10.0-alpha.1...v5.10.0-alpha.2) (2024-12-16)

### Bug Fixes

* dont load textdomain too early ([#3629](#3629)) ([76c1f97](76c1f97))
* hide duplicate notices if all was dismissed ([#3630](#3630)) ([cf48188](cf48188))
* **recaptcha:** add safeguards against duplicate renders ([#3624](#3624)) ([d95ee7e](d95ee7e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.10.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 16, 2024
@semantic-release-bot
chore(release): 5.10.0 [skip ci]
359f743 
# [5.10.0](v5.9.2...v5.10.0) (2024-12-16)

### Bug Fixes

* dont load textdomain too early ([#3629](#3629)) ([76c1f97](76c1f97))
* duplicate orders save on cron ([#3604](#3604)) ([ec69167](ec69167))
* hide duplicate notices if all was dismissed ([#3630](#3630)) ([cf48188](cf48188))
* **ras-acc:** re-add recaptcha to the WooCommerce checkout ([#3605](#3605)) ([f42a75b](f42a75b))
* **ras:** do not require Woo plugins if using NRH ([#3614](#3614)) ([363a834](363a834))
* **wcs:** remove subscriptions expiration feature flag ([#3618](#3618)) ([7c175d9](7c175d9))
* **wcs:** update subscription expiration feature ([#3613](#3613)) ([ebf6e6d](ebf6e6d))
* **wcs:** update subscriptions expiration cli behavior ([#3617](#3617)) ([07e768c](07e768c))

### Features

* **subscriptions:** add cancellation reason metadata ([#3568](#3568)) ([de83e02](de83e02))
* **wc:** duplicate orders admin notice ([#3555](#3555)) ([cb764e3](cb764e3))
* **wcs:** add expired subscription cli tool ([#3593](#3593)) ([5d39398](5d39398))
* **webhooks:** filter request priority ([#3587](#3587)) ([1928a6a](1928a6a))
* **woocommerce-subscriptions:** add url redirect for wc subscription renewals ([#3525](#3525)) ([5b14aeb](5b14aeb))

### Reverts

* Revert "feat: command to initialize cron job to slowly backfill CAP term data (#3425)" (#3620) ([c9a9d45](c9a9d45)), closes [#3425](#3425) [#3620](#3620)
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees

@leogermani leogermani

Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leogermani @dkoo @matticbot @laurelfulford