fix: add max limit of 5 consecutive scheduled syncs #3639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Adds a mechanism to the
schedule_sync
method so that consecutive scheduled syncs for a single contact will only happen up to a max of five consecutive times. This is to avoid an infinite loop if a contact is scheduled to retry the sync after a failure, but the sync keeps failing.The counter is reset upon a successful sync to the ESP.
How to test the changes in this Pull Request:
Follow instructions in Automattic/newspack-newsletters#1729.
Other information: