Skip to content

Commit

Permalink
Windows: node: [18, 20, 22]
Browse files Browse the repository at this point in the history
  • Loading branch information
cclauss authored Jul 16, 2024
1 parent 16368ef commit 4fd9b33
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
# ENOENT: no such file or directory, lstat 'D:\a\node-canvas\node-canvas\examples\pfennigFont\pfennigMultiByte🚀.ttf'
# ref: https://github.com/nodejs/node/issues/48673
# ref: https://github.com/nodejs/node/pull/50650
node: [18.12.0]
node: [18.12.0, 20, 22]
steps:
- uses: actions/setup-node@v4
with:
Expand All @@ -64,7 +64,7 @@ jobs:
fail-fast: false
matrix:
os: [macos-13, macos-latest]
node: [20, 22]
node: [20, 22] # Node 18 on macOS has node-gyp < v10 which is incompatible with Python 3.12
runs-on: ${{ matrix.os }}
steps:
- uses: actions/setup-node@v4
Expand All @@ -77,8 +77,6 @@ jobs:
brew install cairo giflib jpeg libpng librsvg pango pkg-config
pip install setuptools
- name: Install
# env:
# python: python3.11 # Python 3.12 requires node-gyp >= v10
run: npm install --build-from-source
- name: Test
run: npm test
Expand Down

0 comments on commit 4fd9b33

Please sign in to comment.