Another try to add AppX to artifact links #733
Conversation
wojtekn
force-pushed
the
fix/normalized-version-suffix
branch
from
5919dbe to
a445748
Compare
| @@ -93,6 +93,7 @@ def distribute_builds( | |||
| # If we are distributing a build without a tag, i.e. a development build, we also want to update the latest build reference for distribution. | |||
| update_latest = release_tag.nil? | |||
| suffix = release_tag.nil? ? commit_hash : release_tag | |||
| normalized_version = suffix.gsub(/^v|-.*/, '') | |||
There was a problem hiding this comment.
Added v as without that build script tried to access Studio v1.3.0.0.appx and not Studio 1.3.0.0.appx.
| @@ -248,6 +249,7 @@ steps: | |||
| buildkite-agent artifact download "*.zip" . | |||
| buildkite-agent artifact download "*.dmg" . | |||
| buildkite-agent artifact download "*.exe" . | |||
| buildkite-agent artifact download "*.appx" . | |||
There was a problem hiding this comment.
Build step neees to download the appx files before distributing them.
| name: 'Windows (Appx)' | ||
| }, | ||
| windows_appx_unsigned: { | ||
| binary_path: File.join(BUILDS_FOLDER, 'Studio-appx-unsigned', "Studio #{normalized_version}.0 unsigned.appx"), |
There was a problem hiding this comment.
This approach doesn't work for dev builds as the build script looks for the Studio 287a659.0.appx file name, but the actual filename received from the previous step is Studio 1.3.0.0.appx.
Can we remove the version from the files to match behavior for other artifacts?
wojtekn
changed the title
| windows_appx: { | ||
| binary_path: File.join(BUILDS_FOLDER, 'Studio-appx-signed', "Studio #{normalized_version}.0.appx"), | ||
| filename_core: 'win32', | ||
| extension: 'appx', | ||
| name: 'Windows (Appx)' | ||
| }, |
There was a problem hiding this comment.
I think we don't need the signed version of the appx.
There was a problem hiding this comment.
Yeah, we don't need ZIP, universal, etc. Let's leave it as is for completeness.
It should work automatically, as the code responsible for Slack messages also works around |
Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist