Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add --merge-base to git diff to detect changed files properly #139

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Feb 11, 2024

This accounts for the case when we commit to origin/trunk, but the branch was created from a commit preceding to origin/trunk.

@sjinks sjinks added the bug Something isn't working label Feb 11, 2024
@sjinks sjinks self-assigned this Feb 11, 2024
@sjinks sjinks merged commit 40b5b37 into trunk Feb 11, 2024
3 checks passed
@sjinks sjinks deleted the merge-base branch February 11, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant