Stats: hourly route for Odyssey and Calypso (#96746)

* add hour route for Odyssey * fix tests
Automattic · Nov 25, 2024 · ff4ed83 · ff4ed83
1 parent 8479302
commit ff4ed83
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/apps/odyssey-stats/src/routes.ts b/apps/odyssey-stats/src/routes.ts
@@ -85,6 +85,7 @@ const redirectToSiteTrafficPage = () => {
 
 export default function ( pageBase = '/' ) {
 	const validPeriods = [ 'day', 'week', 'month', 'year' ].join( '|' );
+	const validTrafficPagePeriods = [ 'hour', 'day', 'week', 'month', 'year' ].join( '|' );
 	const validEmailPeriods = [ 'hour', 'day' ].join( '|' );
 
 	const validModules = [
@@ -116,7 +117,7 @@ export default function ( pageBase = '/' ) {
 	statsPage( `/stats/subscribers/:period(${ validPeriods })/:site`, subscribers );
 
 	// Stat Site Pages
-	statsPage( `/stats/:period(${ validPeriods })/:site`, site );
+	statsPage( `/stats/:period(${ validTrafficPagePeriods })/:site`, site );
 
 	// Redirect this to default /stats/day/:module/:site view to
 	// keep the paths and page view reporting consistent.

diff --git a/client/my-sites/stats/index.js b/client/my-sites/stats/index.js
@@ -27,7 +27,8 @@ const statsPage = ( url, controller ) => {
 };
 
 export default function () {
-	const validPeriods = [ 'hour', 'day', 'week', 'month', 'year' ].join( '|' );
+	const validPeriods = [ 'day', 'week', 'month', 'year' ].join( '|' );
+	const validTrafficPagePeriods = [ 'hour', 'day', 'week', 'month', 'year' ].join( '|' );
 	const validEmailPeriods = [ 'hour', 'day' ].join( '|' );
 
 	const validModules = [
@@ -64,7 +65,7 @@ export default function () {
 	statsPage( `/stats/subscribers/:period(${ validPeriods })/:site`, subscribers );
 
 	// Stat Site Pages
-	statsPage( `/stats/:period(${ validPeriods })/:site`, site );
+	statsPage( `/stats/:period(${ validTrafficPagePeriods })/:site`, site );
 
 	// Redirect this to default /stats/day/:module/:site view to
 	// keep the paths and page view reporting consistent.

diff --git a/client/my-sites/stats/test/index.js b/client/my-sites/stats/test/index.js
@@ -55,7 +55,8 @@ const validModules = [
 	'devices',
 ].join( '|' );
 
-const validPeriods = [ 'hour', 'day', 'week', 'month', 'year' ].join( '|' );
+const validPeriods = [ 'day', 'week', 'month', 'year' ].join( '|' );
+const validTrafficPagePeriods = [ 'hour', 'day', 'week', 'month', 'year' ].join( '|' );
 
 const routes = {
 	[ `/stats/:period(${ validPeriods })` ]: [
@@ -67,7 +68,7 @@ const routes = {
 	],
 	'/stats/insights': [ siteSelection, navigation, sites, makeLayout, clientRender ],
 	'/stats/insights/:site': [ siteSelection, navigation, insights, makeLayout, clientRender ],
-	[ `/stats/:period(${ validPeriods })/:site` ]: [
+	[ `/stats/:period(${ validTrafficPagePeriods })/:site` ]: [
 		siteSelection,
 		navigation,
 		site,
@@ -83,7 +84,6 @@ const routes = {
 		clientRender,
 	],
 	'/stats/post/:post_id/:site': [ siteSelection, navigation, post, makeLayout, clientRender ],
-
 	'/stats/page/:post_id/:site': [ siteSelection, navigation, post, makeLayout, clientRender ],
 	'/stats/follows/comment/:site': [ siteSelection, navigation, follows, makeLayout, clientRender ],
 	'/stats/follows/comment/:page_num/:site': [