Plans Grid: fix simplified display behaviour

[aneeshd16]

Fixes #97489

Proposed Changes

This is a follow-up to #95977.

The simplified plans grid is now the default and should be shown in all plans grids. Some variations of the plans grid, specifically with the 'plans-newsletter', 'plans-link-in-bio', 'plans-blog-onboarding' intents, display a different set of features. These intents and flows will soon be removed. (p5uIfZ-ggB-p2#comment-24253).

The previous check implemented in #95977 was too restrictive and resulted in the "Everything in {previous_plan}, plus:" text being shown for plans grids with intents other than the default (plans-default-wpcom) and the ones listed above.

This PR fixes it by changing the check to ensure the simplified grid is shown in all cases except when the intents are 'plans-newsletter', 'plans-link-in-bio', 'plans-blog-onboarding'.

Why are these changes being made?

• Bug fix.

Testing Instructions

• Go to /domains/manage/all/<domain>/edit/<domain> for a domain-only purchase.
• Click on "Add a new site".
• On the plans step, confirm that the plans grid does not have the text "Everything in {previous_plan}, plus:".
• Smoke test /start, /setup/newsletter/plans and /plans/<site slug> to ensure that they are unchanged from production.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-4875d54a562c88cc71dac4eab87ca4156b057c2e

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-4875d54a562c88cc71dac4eab87ca4156b057c2e&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-4875d54a562c88cc71dac4eab87ca4156b057c2e&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
update-design-flow          +21 B  (+0.0%)       -1 B  (-0.0%)
plugins                     +21 B  (+0.0%)       -1 B  (-0.0%)
plans                       +21 B  (+0.0%)       -1 B  (-0.0%)
link-in-bio-tld-flow        +21 B  (+0.0%)       -1 B  (-0.0%)
jetpack-app                 +21 B  (+0.0%)       -1 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected        +21 B  (+0.0%)       -1 B  (-0.0%)
async-load-signup-steps-plans                          +21 B  (+0.0%)       -1 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[southp]

It works as described and LGTM 🚢