Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Profiler: fixes navbar position #97506

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

cpapazoglou
Copy link
Contributor

@cpapazoglou cpapazoglou commented Dec 16, 2024

Related to p58i-iWu-p2#comment-65329
Fixes #97457

Proposed Changes

  • Puts the navbar lower in zindex stack so that admin bar popup links are shown.

Testing Instructions

Before After
CleanShot 2024-12-16 at 10 32 42 CleanShot 2024-12-16 at 10 31 57

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@cpapazoglou cpapazoglou self-assigned this Dec 16, 2024
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well, I can see the popup on top of the button now. LGTM! :shipit:

CleanShot 2024-12-16 at 09 36 40@2x

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/performance-profiler-nav-bar-position on your sandbox.

@cpapazoglou cpapazoglou merged commit 602bf8d into trunk Dec 16, 2024
10 of 12 checks passed
@cpapazoglou cpapazoglou deleted the fix/performance-profiler-nav-bar-position branch December 16, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Make "WordPress Speed Test" badge text consistent across pages
3 participants