Checkout: Remove wpcom-proxy-request from calypso-paypal package #97525
+4
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR removes the
wpcom-proxy-request
from the dependencies of@automattic/calypso-paypal
.Why are these changes being made?
Originally, I had added
wpcom-proxy-request
to thecalypso-paypal
package as a way to have the package make its own HTTP API requests to the WPCOM paypal configuration endpoint. However, it appears that in some cases this does not work well, so in #97487 I made checkout inject its own network request function as an argument. Since that seems to always work, this PR will make that technique required and remove the ability for the package to make its own calls.Testing Instructions
Add a product to your cart and visit checkout. Verify that you see PayPal as a payment method option listed.