Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holiday Snow: allow usage on p2s as well #97527

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 16, 2024

Proposed Changes

This effectively reverts #97238

Why are these changes being made?

If Automattic/jetpack#40629 gets merged, we will be able to use Holiday Snow on p2s on WordPress.com. We will consequently be able to display the settings to enable the feature again.

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

This effectively reverts #97238

If Automattic/jetpack#40629 gets merged, we will be able to use Holiday Snow on p2s on WordPress.com. We will consequently be able to display the settings to enable the feature again.
@jeherve jeherve added [Type] Enhancement [Feature] Site Settings All other general site settings. [Pri] Normal Schedule for the next available opportuinity. [Status] Blocked / Hold [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. labels Dec 16, 2024
@jeherve jeherve self-assigned this Dec 16, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/snow-p2 on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~31 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
site-settings       -113 B  (-0.0%)      -31 B  (-0.0%)
settings             -23 B  (-0.0%)       -6 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Feature] Site Settings All other general site settings. [Pri] Normal Schedule for the next available opportuinity. [Status] Blocked / Hold [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants