Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Picker: Save the selected global styles to the onboard stores #97543

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

arthur791004
Copy link
Contributor

Related to #97540

Proposed Changes

  • Save the selected global styles to the onboard stores so we can get the data in different flows

Why are these changes being made?

  • Store the global styles between different onboarding flows

Testing Instructions

  • Create a new site
  • On the Goals screen, select any goals
  • On the Design Picker screen,
    • Select a design with the style variation, and ensure it works as before
    • Select a design with the color/font variation, and ensure it works as before

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Dec 17, 2024
@arthur791004 arthur791004 requested review from a team December 17, 2024 07:50
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 17, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug feat/design-picker-save-global-styles on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~52 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +317 B  (+0.0%)      +52 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~50 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
subscribers         +317 B  (+0.0%)      +50 B  (+0.0%)
staging-site        +317 B  (+0.0%)      +50 B  (+0.0%)
site-tools          +317 B  (+0.0%)      +50 B  (+0.0%)
site-settings       +317 B  (+0.0%)      +50 B  (+0.0%)
settings            +317 B  (+0.0%)      +50 B  (+0.0%)
home                +317 B  (+0.0%)      +50 B  (+0.0%)
checkout            +317 B  (+0.0%)      +50 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and observed no regression ✅

Copy link
Contributor

@candy02058912 candy02058912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the /start flow.

@arthur791004 arthur791004 merged commit cad8957 into trunk Dec 17, 2024
15 of 16 checks passed
@arthur791004 arthur791004 deleted the feat/design-picker-save-global-styles branch December 17, 2024 08:10
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants