This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
add templates #42
Merged
add templates #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zghera
suggested changes
Feb 6, 2022
There was a problem hiding this comment.
Could you add to the checklist in the pull request template? I started a draft PR with some checklist additions in #30 but I wasn't sure what all to include as some things may be verified by CI here soon (so not sure if we should have a checklist for some of them). Give it a look and add what you think makes sense.
Otherwise looks good!
|
Changed only one bullet list. The other two should be fixed by Issue #32. |
zghera
approved these changes
Feb 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
Added issues template
Is this fixing an issue?
No
Were any issues created as a result of this change?
No
Are there more details that are relevant?
No
Check lists (check x in [ ] of list items)
Any additional comments?