Precompute the rank of a data node in all the scenario config DAGs. #2072

jrobinAV · 2024-10-16T15:00:30Z

resolves #2071

Each data node configuration now has a _rank attribute as a dictionary.
When configuring a new scenario configuration, all the nested data node configurations are updated. An entry is added in the DataNodeConfig._rank dictionary. The key is the scenario config ID, and the value is the rank of the data node in the scenario config DAG.
Each data node exposes a hidden API to retrieve its _rank for a given scenario configuration.

taipy/core/config/scenario_config.py

FlorianJacta

I agree with the principle. I let the others review the code 😄

FredLL-Avaiga

with comment

taipy/core/config/scenario_config.py

github-actions · 2024-10-17T12:28:40Z

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
19485	16951	87%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
taipy/core/config/data_node_config.py	99%	🟢
taipy/core/config/scenario_config.py	88%	🟢
taipy/core/data/data_node.py	98%	🟢
taipy/gui_core/_adapters.py	53%	🟢
taipy/gui_core/_context.py	62%	🟢
taipy/gui_core/filters.py	67%	🟢
TOTAL	78%	🟢

updated for commit: 59afe69 by action🐍

trgiangdo

Minor comments

taipy/core/data/data_node.py

trgiangdo

LGTM

toan-quach

lgtm :D

jrobinAV · 2024-10-31T08:57:43Z

Actually LNGTM.

I don't like it, and I'm having difficulty explaining why. Please give me some time to figure it out.

github-actions · 2024-11-14T09:06:02Z

This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines.

- get_rank with scenario config id - hide empty branch on search

github-actions · 2024-11-29T09:56:59Z

Coverage report for `./frontend/taipy`

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 51.87376725838264%

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	51.87% (-0.21% 🔻)	263/507
🔴	Branches	21.61% (-0.14% 🔻)	67/310
🔴	Functions	14.66%	17/116
🔴	Lines	53.19% (-0.23% 🔻)	242/455

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🔴	CoreSelector.tsx	31.32% (-0.24% 🔻)	15.53% (-0.15% 🔻)	15.38%	33.33% (-0.28% 🔻)

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 59afe69

taipy/core/data/data_node.py

Co-authored-by: Jean-Robin <jeanrobin.medori@avaiga.com>

github-actions · 2024-12-03T09:13:40Z

Coverage report for `./frontend/taipy-gui`

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 69.12402428447528%

St.^❔	Category	Percentage	Covered / Total
🟢	Statements	87.36%	3468/3970
🟡	Branches	69.12%	2391/3459
🟢	Functions	83.16%	642/772
🟢	Lines	87.82%	3210/3655

Test suite run success

701 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from 59afe69

jrobinAV requested review from trgiangdo, FabienLelaquais, joaoandre-avaiga, FredLL-Avaiga, toan-quach and FlorianJacta October 16, 2024 15:00

jrobinAV mentioned this pull request Oct 16, 2024

Rank data nodes by topological order in the data node selector #2071

Closed

jrobinAV commented Oct 16, 2024

View reviewed changes

taipy/core/config/scenario_config.py Outdated Show resolved Hide resolved

FlorianJacta previously approved these changes Oct 16, 2024

View reviewed changes

jrobinAV dismissed FlorianJacta’s stale review via fc78e2c October 16, 2024 15:37

jrobinAV added Core Related to Taipy Core 🖰 GUI Related to GUI 🟨 Priority: Medium Not blocking but should be addressed labels Oct 16, 2024

jrobinAV self-assigned this Oct 16, 2024

FredLL-Avaiga previously approved these changes Oct 17, 2024

View reviewed changes

taipy/core/config/scenario_config.py Outdated Show resolved Hide resolved

jrobinAV dismissed FredLL-Avaiga’s stale review via 71bc275 October 17, 2024 11:58

FredLL-Avaiga self-assigned this Oct 17, 2024

trgiangdo reviewed Oct 19, 2024

View reviewed changes

taipy/core/data/data_node.py Outdated Show resolved Hide resolved

taipy/core/data/data_node.py Outdated Show resolved Hide resolved

FredLL-Avaiga requested review from trgiangdo, FlorianJacta and FredLL-Avaiga October 19, 2024 10:33

jrobinAV and others added 7 commits October 22, 2024 10:25

Precompute the rank of a data node in all the scenario config DAGs.

0c6205d

Update taipy/core/config/scenario_config.py

e20bbf5

linter

2a31b4b

Fredd's feedback

ab593ba

fix wrong test

e6285e1

sort/filter Datanodes by rank

5d4aa27

@trgiangdo comments

dbd2949

FredLL-Avaiga force-pushed the feature/#2071-rank-datanodes-in-selector branch from 1c622f9 to dbd2949 Compare October 22, 2024 08:26

Merge branch 'develop' into feature/#2071-rank-datanodes-in-selector

39276e5

trgiangdo previously approved these changes Oct 31, 2024

View reviewed changes

toan-quach previously approved these changes Oct 31, 2024

View reviewed changes

github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 14, 2024

FredLL-Avaiga removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 14, 2024

Merge branch 'develop' into feature/#2071-rank-datanodes-in-selector

a6317fe

jrobinAV marked this pull request as draft November 27, 2024 11:43

Open _get_rank(scenario_config_id) API in DataNode class

3ba5c9c

jrobinAV dismissed stale reviews from trgiangdo and toan-quach via 3ba5c9c November 27, 2024 12:32

jrobinAV and others added 3 commits November 27, 2024 13:34

Merge branch 'develop' into feature/#2071-rank-datanodes-in-selector

f55f699

Merge branch 'develop' into feature/#2071-rank-datanodes-in-selector

4d43793

- tree by ownership

f2c12f2

- get_rank with scenario config id - hide empty branch on search

lint

84d2fec

jrobinAV commented Nov 29, 2024

View reviewed changes

taipy/core/data/data_node.py Outdated Show resolved Hide resolved

JR doc

4d18c1e

Co-authored-by: Jean-Robin <jeanrobin.medori@avaiga.com>

FredLL-Avaiga requested review from trgiangdo and toan-quach November 29, 2024 12:45

Merge branch 'develop' into feature/#2071-rank-datanodes-in-selector

b05931f

jrobinAV marked this pull request as ready for review December 3, 2024 09:06

Merge branch 'develop' into feature/#2071-rank-datanodes-in-selector

ea7a7e2

jrobinAV added 3 commits December 3, 2024 10:45

Code factorization and code formatting after merge

7d2ab36

Merge branch 'develop' into feature/#2071-rank-datanodes-in-selector

0d0f0db

Fix linter

59afe69

jrobinAV merged commit dd9f3ad into develop Dec 9, 2024
133 checks passed

jrobinAV deleted the feature/#2071-rank-datanodes-in-selector branch December 9, 2024 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Precompute the rank of a data node in all the scenario config DAGs. #2072

Precompute the rank of a data node in all the scenario config DAGs. #2072

jrobinAV commented Oct 16, 2024 •

edited

Loading

FlorianJacta left a comment

FredLL-Avaiga left a comment

github-actions bot commented Oct 17, 2024 •

edited

Loading

trgiangdo left a comment

trgiangdo left a comment

toan-quach left a comment

jrobinAV commented Oct 31, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 29, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024 •

edited

Loading

Precompute the rank of a data node in all the scenario config DAGs. #2072

Precompute the rank of a data node in all the scenario config DAGs. #2072

Conversation

jrobinAV commented Oct 16, 2024 • edited Loading

FlorianJacta left a comment

Choose a reason for hiding this comment

FredLL-Avaiga left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 17, 2024 • edited Loading

☂️ Python Coverage

Overall Coverage

New Files

Modified Files

trgiangdo left a comment

Choose a reason for hiding this comment

trgiangdo left a comment

Choose a reason for hiding this comment

toan-quach left a comment

Choose a reason for hiding this comment

jrobinAV commented Oct 31, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 29, 2024 • edited Loading

Coverage report for ./frontend/taipy

Test suite run success

github-actions bot commented Dec 3, 2024 • edited Loading

Coverage report for ./frontend/taipy-gui

Test suite run success

jrobinAV commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Nov 29, 2024 •

edited

Loading

Coverage report for `./frontend/taipy`

github-actions bot commented Dec 3, 2024 •

edited

Loading

Coverage report for `./frontend/taipy-gui`