Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies [pyarrow, flask related] (#2239) #2248

Merged
merged 6 commits into from
Nov 16, 2024
Merged

Update dependencies [pyarrow, flask related] (#2239) #2248

merged 6 commits into from
Nov 16, 2024

Conversation

dinhlongviolin1
Copy link
Member

@dinhlongviolin1 dinhlongviolin1 commented Nov 14, 2024 •
edited
Loading

Resolve #2239

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19291 16776 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/setup.py 0% 🟢
taipy/gui/setup.py 0% 🟢
TOTAL 0% 🟢

updated for commit: 39ae70a by action🐍

@dinhlongviolin1 dinhlongviolin1 self-assigned this Nov 14, 2024
@dinhlongviolin1 dinhlongviolin1 added 🖧 Devops Operations, monitoring, maintenance, deployment, packaging 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be addressed as soon as possible labels Nov 14, 2024
@dinhlongviolin1 dinhlongviolin1 changed the title fix pipenv version Fix tests failing due to dependencies (#2239) Nov 14, 2024
FabienLelaquais
FabienLelaquais previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dinhlongviolin1
Copy link
Member Author

@joaoandre I have just seen your PR. I guess we came up with the same solution :D

FredLL-Avaiga
FredLL-Avaiga previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a few questions

.github/workflows/partial-tests.yml Show resolved Hide resolved
Pipfile Show resolved Hide resolved
tools/packages/taipy-gui/setup.requirements.txt Show resolved Hide resolved
jrobinAV
jrobinAV reviewed Nov 14, 2024
View reviewed changes
Pipfile Show resolved Hide resolved
Pipfile Show resolved Hide resolved
@dinhlongviolin1 dinhlongviolin1 changed the title Fix tests failing due to dependencies (#2239) Update dependencies [pyarrow, flask related] (#2239) Nov 15, 2024
FabienLelaquais
FabienLelaquais approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@dinhlongviolin1 dinhlongviolin1 merged commit 1668422 into develop Nov 16, 2024
125 of 126 checks passed
@dinhlongviolin1 dinhlongviolin1 added the 📝Release Notes Impacts the Release Notes or the Documentation in general label Nov 16, 2024
@dinhlongviolin1 dinhlongviolin1 deleted the bug/fix-pipenv-tests branch November 16, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredLL-Avaiga FredLL-Avaiga FredLL-Avaiga approved these changes

@jrobinAV jrobinAV jrobinAV approved these changes

@FabienLelaquais FabienLelaquais FabienLelaquais approved these changes

@joaoandre-avaiga joaoandre-avaiga Awaiting requested review from joaoandre-avaiga

Assignees

@dinhlongviolin1 dinhlongviolin1

Labels
🖧 Devops Operations, monitoring, maintenance, deployment, packaging 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be addressed as soon as possible 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] Test action failing on some configurations
5 participants
@dinhlongviolin1 @FabienLelaquais @jrobinAV @joaoandre-avaiga @FredLL-Avaiga