-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle icons for status #2264
handle icons for status #2264
Conversation
linked to #1157
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 52.08% | 263/505 |
🔴 | Branches | 21.75% | 67/308 |
🔴 | Functions | 14.66% | 17/116 |
🔴 | Lines | 53.42% | 242/453 |
Test suite run success
7 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 52cfbb4
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please:
- replace 'icons' -> 'use_icon'
- Make this property indexed:
use_icon[warning] = True
use_icon[e]=<inline_svg>|URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All examples should have the same header, potentially with a few line of specific information for that code.
See doc/gui/examples/broadcast_callback.py for example...
What type of PR is this? (check all applicable)
Description
Simplify the work done in the hacktoberfest PR
only new property is icons: Union[bool, list[str]]
if false, no icons,
if true: pre-defined icons
if list, for each element:
.svg
) or SVG string (starts with<svg
)Related Tickets & Documents
How to reproduce the issue
Checklist