Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree does not support mode #2279

Merged
merged 4 commits into from
Nov 25, 2024
Merged

tree does not support mode #2279

merged 4 commits into from
Nov 25, 2024

Conversation

FredLL-Avaiga
Copy link
Member

resolves #2278

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Tree does not support property mode

Related Tickets & Documents

How to reproduce the issue

import taipy.gui.builder as tgb
from taipy.gui import Gui

x = ""
lov = [
    {
        "id": "1",
        "label": "P",
        "children": [{"id": "2", "label": "C1", "children": []}, {"id": "3", "label": "C2", "children": []}],
    }
]

with tgb.Page() as root:
    tgb.text("Here's a Tree:")
    tgb.tree("{x}", mode="check", lov="{lov}")
    tgb.text("Here's a Selector:")
    tgb.selector("{x}", mode="check", lov="{lov}")

if __name__ == "__main__":
    Gui(root).run(title="2278 [🐛 BUG] The checkbox / radio mode does not work in tree view")

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 52.07920792079208%

St.
Category Percentage Covered / Total
🔴 Statements 52.08% 263/505
🔴 Branches 21.75% 67/308
🔴 Functions 14.66% 17/116
🔴 Lines 53.42% 242/453

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 84681c0

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 69.4093446958566%

St.
Category Percentage Covered / Total
🟢 Statements 87.49% 3454/3948
🟡 Branches 69.41% 2362/3403
🟢 Functions 83.2% 639/768
🟢 Lines 87.97% 3197/3634

Test suite run success

698 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from 84681c0

Copy link
Contributor

github-actions bot commented Nov 25, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19334 16809 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/builder/_api_generator.py 86% 🟢
taipy/gui/utils/viselements.py 97% 🟢
TOTAL 92% 🟢

updated for commit: 84681c0 by action🐍

@FredLL-Avaiga FredLL-Avaiga added 📈 Improvement Improvement of a feature. 📄 Documentation Internal or public documentation 🖰 GUI Related to GUI 🟨 Priority: Medium Not blocking but should be addressed 📝Release Notes Impacts the Release Notes or the Documentation in general labels Nov 25, 2024
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😶

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ez one for you

@FredLL-Avaiga FredLL-Avaiga merged commit e5c10d4 into develop Nov 25, 2024
133 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the bug/#2278-tree-mode branch November 25, 2024 18:39
@sumanth-tccc
Copy link

Hi Guys . The dropdown also is not working like <|..|selector|dropdown=True|>

@sumanth-tccc
Copy link

sumanth-tccc commented Nov 26, 2024

x = ""
lov = [
    {
        "id": "1",
        "label": "P",
        "children": [
                           {"id": "1.2", "label": "C1", "children": []},
                           {"id": "1.3", "label": "C2", "children": []}
                          ],
    },
    {
        "id": "2",
        "label": "q",
        "children": [
                           {"id": "2.2", "label": "Q1", "children": []},
                           {"id": "2.3", "label": "Q2", "children": []}
                          ],
    },
]

with tgb.Page() as root:
    tgb.text("Here's a Tree:")
    tgb.tree("{x}", mode="check", lov="{lov}")
    tgb.text("Here's a Selector:")
    tgb.selector("{x}", mode="check", lov="{lov}")

if __name__ == "__main__":
    Gui(root).run(title="2278 [🐛 BUG] The checkbox / radio mode does not work in tree view")

The drop down true keeps all of them active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 Documentation Internal or public documentation 🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] The checkbox / radio mode does not work in tree view
4 participants