-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/#398-expand-exposed-type-parameter #2296
base: develop
Are you sure you want to change the base?
feature/#398-expand-exposed-type-parameter #2296
Conversation
…tps://github.com/sohamkumar05/taipy into feature/Avaiga#398-expand-exposed-type-parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sohamkumar05 for your contribution with the Pull Request.
I believe the PR is in a good shape. There are a few refinements needed, and then the Taipy team will do some testing before we can merge your PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me. I believe it's almost ready to be merged.
I have 1 more request just to make sure this works properly with Taipy serialization.
Can you write a few test cases exploring cases where instead of import pandas as pd
and use pd.DataFrame
as the exposed_type
, do:
import pandas
and usepandas.DataFrame
from pandas import DataFrame
and use just theDataFrame
from pandas import DataFrame as DF
and useDF
Similarly, try different imports for np.ndarray
What type of PR is this? (check all applicable)
Description
We are also including pandas.DataFrame and numpy.ndarray as exposed type.
Related Tickets & Documents
exposed_type
parameter of DataNode to accept actual Python types #398exposed_type
parameter of DataNode to accept actual Python types #398How to reproduce the issue
Checklist
We encourage you to keep the code coverage percentage at 80% and above.