Adding example for get_resource for taipy extension #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namnguyen20999
requested review from
dinhlongviolin1,
FabienLelaquais and
FredLL-Avaiga
namnguyen20999
changed the title
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
FabienLelaquais
requested changes
Dec 3, 2024
|
|
||
|
|
||
| class ExampleLibrary(ElementLibrary): | ||
| def __init__(self) -> None: | ||
| # Initialize the set of visual elements for this extension library | ||
|
|
||
| logo_path = self.get_resource("resources/taipy_logo.png") |
There was a problem hiding this comment.
The best I think would be to change the path not to confuse users about what we're looking for and where.
I also rename the image file itself for simplicity.
Suggested change
| logo_path = self.get_resource("resources/taipy_logo.png") | |
| logo_path = self.get_resource("icons/logo.png") |
There was a problem hiding this comment.
Rename to doc/gui/extension/example_library/assets/icons/logo.png
FabienLelaquais
added
🖰 GUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adding an example for get_resources for taipy extension
Checklist
We encourage you to keep the code coverage percentage at 80% and above.