Fix/#417 - _update() of CoreSection should not use the _replace_templates() #549

trgiangdo · 2023-12-05T09:35:48Z

trgiangdo requested a review from jrobinAV December 5, 2023 09:35

jrobinAV previously approved these changes Dec 5, 2023

View reviewed changes

trgiangdo dismissed jrobinAV’s stale review via d9f1108 December 11, 2023 08:54

trgiangdo force-pushed the fix/#417-update-coresection-use-template branch from 219982f to d9f1108 Compare December 11, 2023 08:54

jrobinAV previously approved these changes Dec 11, 2023

View reviewed changes

trgiangdo dismissed jrobinAV’s stale review via ef198d0 December 13, 2023 03:58

jrobinAV previously approved these changes Dec 13, 2023

View reviewed changes

trgiangdo added 3 commits December 13, 2023 17:15

fix: _update() of CoreSection should not use the _replace_templates()

d9761f5

fix: linter error

d8afb99

fix: _update() method should update the internal attributes

12eb2b7

trgiangdo force-pushed the fix/#417-update-coresection-use-template branch from ef198d0 to 12eb2b7 Compare December 13, 2023 10:15

fix: linter error

e291eb4

trgiangdo dismissed jrobinAV’s stale review via e291eb4 December 13, 2023 10:22

trgiangdo requested a review from jrobinAV December 13, 2023 10:57

jrobinAV approved these changes Dec 13, 2023

View reviewed changes

jrobinAV merged commit 917c5bb into develop Dec 13, 2023
14 of 23 checks passed

jrobinAV deleted the fix/#417-update-coresection-use-template branch December 13, 2023 18:05

Provide feedback