Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evaluate datatype without pandas for strings (#601) #602

Merged
merged 1 commit into from
Dec 12, 2023
Merged

evaluate datatype without pandas for strings (#601) #602

merged 1 commit into from
Dec 12, 2023

Conversation

FredLL-Avaiga
Copy link
Member 

from taipy.gui import Gui

some_text = "b"

Gui("<|{some_text}|>").run()

@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible 💥Malfunction Addresses an identified problem. 📝Release Notes Impacts the Release Notes or the Documentation in general Gui: Back-End labels Dec 12, 2023
@FredLL-Avaiga FredLL-Avaiga self-assigned this Dec 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

Coverage report for frontend/taipy-gui

Branches coverage not met for global: expected >=80%, but got 62.35086168802475%

St.❔
 Category Percentage Covered / Total
🟢 Statements
80.65% (+0.05% 🔼)
 2296/2847
🟡 Branches
62.35% (-0.59% 🔻)
 1411/2263
🟡 Functions
74.81% (-0.29% 🔻)
 401/536
🟢 Lines
81.03% (+0.07% 🔼)
 2132/2631
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / Dialog.tsx
 80.43% 60.87% 100% 80.43%
🟡
... / TaipyRendered.tsx
 66.67% 17.65% 50% 66.67%
🟡
... / index.ts
 73.33% 26.67% 50% 72.73%
🟢
... / Expandable.tsx
 100% 85% 100% 100%
🟢
... / PageContent.tsx
 75% 100% 0% 100%
🟢
... / Pane.tsx
 95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
 88% 64.29% 75% 91.3%
🟡
... / Unregistered.tsx
 62.5% 0% 0% 60%

Test suite run success

334 tests passing in 36 suites.

Report generated by 🧪jest coverage report action from 668f0d8

FabienLelaquais
FabienLelaquais approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dinhlongviolin1
dinhlongviolin1 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FredLL-Avaiga FredLL-Avaiga merged commit 83b6899 into develop Dec 12, 2023
27 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the bug/#601-pandas-dtype-string branch December 12, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienLelaquais FabienLelaquais FabienLelaquais approved these changes

@dinhlongviolin1 dinhlongviolin1 dinhlongviolin1 approved these changes

Assignees

@FredLL-Avaiga FredLL-Avaiga

Labels
Gui: Back-End 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be addressed as soon as possible 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FredLL-Avaiga @dinhlongviolin1 @FabienLelaquais