Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build taipy frontend package simply #629

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

FredLL-Avaiga
Copy link
Member

rename TAIPY_GUI_DIR to TAIPY_DIR

rename TAIPY_GUI_DIR to TAIPY_DIR
@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible 📈 Improvement Improvement of a feature. 📝Release Notes Impacts the Release Notes or the Documentation in general GUI: Front-End labels Dec 21, 2023
@FredLL-Avaiga FredLL-Avaiga self-assigned this Dec 21, 2023
Copy link
Contributor

github-actions bot commented Dec 21, 2023

Coverage report for frontend/taipy-gui

Branches coverage not met for global: expected >=80%, but got 62.36749116607774%

St.
Category Percentage Covered / Total
🟢 Statements 80.6% 2289/2840
🟡 Branches 62.37% 1412/2264
🟡 Functions 74.72% 399/534
🟢 Lines 80.98% 2125/2624

Test suite run success

334 tests passing in 36 suites.

Report generated by 🧪jest coverage report action from 6fddce2

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some 🔮pieces here and there, but hey...

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@FredLL-Avaiga FredLL-Avaiga merged commit 3f4903b into develop Dec 22, 2023
49 of 52 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the build/taipy-frontend-package branch December 22, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 📈 Improvement Improvement of a feature. 🟥 Priority: Critical Must be addressed as soon as possible 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants