Raise the EffectiveViewPortChanged
when a control is added to the tree that has already has a valid layout
#17570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fix the raising of the EffectiveViewPortChanged event.
What is the current behavior?
If you add a control that expects the
EffectiveViewPortChanged
event to a tree that has already has a valid layout, it never receives the event, giving the initial value.The reason is because when the listener is added
new EffectiveViewportChangedListener(
control,
CalculateEffectiveViewport(control));
When this is being added to a parent that has a size a size here is calculated.
Now when the actual layout pass happens
LayoutManager -> RaiseEffectiveViewportChanged()
viewport and l.Viewport are equal and the event is skipped.
What is the updated/expected behavior with this PR?
We now match the UWP behavior of raising the event.
How was the solution implemented (if it's not obvious)?
ViewPort
property.ViewPort
property nullable, so that it has to raise it the first time.This other PR updates the UWP tests that prove our behaviour is the same.
grokys/EffectiveBoundsTestsUWP#1
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues