Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix add-content-to-dialog.md #430

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

draptik
Copy link
Contributor

@draptik draptik commented Mar 30, 2024

Fix namespace

Copy link
Collaborator

@stevemonaco stevemonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was broken in a prior PR "fix". Can you mention somewhere that the UserControl created prior in the same doc should be within the Avalonia.MusicStore.Views namespace?

@draptik
Copy link
Contributor Author

draptik commented Apr 28, 2024

This was broken in a prior PR "fix". Can you mention somewhere that the UserControl created prior in the same doc should be within the Avalonia.MusicStore.Views namespace?

This seems to be the case already:

image

Or did I miss something?

@stevemonaco
Copy link
Collaborator

Not exactly correct. There's a current issue with folder namespaces with inconsistency between the AvaloniaVS extension and avalonia-dotnet-templates. I'm still waiting for confirmation and then I'll probably close the related PRs in this repo and PR it myself so I can be more thorough across all of the guided tutorials. AvaloniaUI/avalonia-dotnet-templates#255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants