Numerical and Categorical Pre-Processing PR #29
Conversation
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
There was a problem hiding this comment.
@Lycons-rage LGTM. do these necessary changes.
Also enlist these algorithms in the readme file created by me.
| The class includes basic exception handling: | ||
| - Raises an exception if input data contains null values. | ||
| - Raises an exception if data type is not a pandas DataFrame or NumPy array. | ||
| - Prints an error message if transformation is attempted before fitting the scaler. |
There was a problem hiding this comment.
can you explain this line?
There was a problem hiding this comment.
Should I elaborate the line in readme.md file?
There was a problem hiding this comment.
no explain it only in chat only last line.
There was a problem hiding this comment.
The last line says that if a user tries to call transform function directly, without either calling fit function or fit_transform function first, it will return an exception as fit function calculates the required parameters on the dataset, which, in this case (Min_Max_Scaler) are the minimum and maximum values of each feature. Without them we cannot transform the data.
There was a problem hiding this comment.
remove this file. not required.
There was a problem hiding this comment.
don't delete any file. revoke it.
There was a problem hiding this comment.
don't delete any file. revoke it.
I would've deleted it by mistake...my bad
Avdhesh-Varshney
added
bug 🐛
|
@Lycons-rage you have not committed the required change so to reflect on the pr |
|
@Avdhesh-Varshney I'm facing some issues with my laptop, I'll do it by today for sure |
@Avdhesh-Varshney Could you please tell me in which readme file should i enlist the algorithms |
Closes: #18 [FEATURE REQUEST] Adding Pre-Processing Techniques for numerical as well as categorical features
Describe the add-ons or changes you've made 📃
Added 3 directories, named, Min_Max_Scaler (Normalization), Standard_Scaler (Standardization), Ordinal_Encoding (Categorical Feature Handling), each having testing and images subdirectories along with the python script and testing files and respective readme.md files.
Type of change ☑️
What sort of change have you made:
How Has This Been Tested? ⚙️
Checklist: ☑️
Screenshots 📷