New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backwards pagination and filtering in `FormFieldsConnectionResolver` #420

Merged

justlevine merged 1 commit into AxeWP:develop from justlevine:fix/form-field-filters-pagination

Jun 2, 2024

Member

justlevine commented Jun 2, 2024

What

This PR:

Fixes FormField backwards pagination
Fixes FormField filters
Backfills tests for FormField connections

Why

How

Testing Instructions

Additional Info

Checklist:

This PR is tested to the best of my abilities.
This PR follows the WordPress Coding Standards.
This PR has proper inline documentation.
This PR has unit tests to verify the code works as intended.
The changes in this PR have been noted in CHANGELOG.md


          fix: backwards pagination and filtering in FormFieldsConnectionResolver

c15f626

justlevine added the safe to test ✔ label

justlevine merged commit e68b7c0 into AxeWP:develop

17 of 18 checks passed

justlevine deleted the fix/form-field-filters-pagination branch

June 2, 2024 13:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test ✔