fix: handle RadioField submission values when using a custom "other" choice. #421
+389
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds explicit handling for
gf_other_choiceandinput_%id%_otheron RadioField submissions.This is a nonbreaking change.
Why
After GF made internal changes to their state management in 2.7 (2.6?), passing a custom choice value would fail validation. However we had no tests in place to let us know this stopped working 🤦.
This was reported as a documentation issue in #390 and #417 , but it was actually a bug.
How
The submission still takes a
valueas usual, If the Radio field has choices enabled, then we set the necessary GF_Entry input values.Testing Instructions
Additional Info
Checklist: