fix!: Keep PageField with previous page data when filtering formFields by pageNumber.
#422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds` by `pageNumber`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR changes the behavior of the
pageNumberfilter on Form Fields connection, so thatGF_Field_Pageis included in the results for the previouspageNumber.This is a breaking change.
Why
As noted in #208 (comment), the
Pagefield includes the data required to create back/next buttons for the page number preceeding it. But because thepageNumberis is for the upcoming page, it misses the field field.How
Testing Instructions
Additional Info
Checklist: