Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check for url before passing it to url_to_postid() #423

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: Check for url before passing it to url_to_postid() #423

merged 1 commit into from
Jun 12, 2024

Conversation

justlevine
Copy link
Member

What

This PR fixes several PHP notices when fetching SubmissionConfirmation.page or SubmissionConfirmation.pageId when there is no associated URL.

Why

How

Check there's a valid url, before passing it to url_to_postid().

Testing Instructions

Additional Info

Checklist:

  • This PR is tested to the best of my abilities.
  • This PR follows the WordPress Coding Standards.
  • This PR has proper inline documentation.
  • This PR has unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

@justlevine justlevine added the safe to test ✔ This PR can be run using repository secrets label Jun 12, 2024
@justlevine justlevine merged commit 50e5cc2 into AxeWP:develop Jun 12, 2024
16 of 35 checks passed
@justlevine justlevine deleted the fix/url_to_postid_notice branch June 12, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
safe to test ✔ This PR can be run using repository secrets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justlevine