Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defender for Cloud Data Connector doc conflict on requirement for sub-level plans #9426

Closed
deggis opened this issue Nov 20, 2023 · 11 comments · Fixed by #9651
Closed

Defender for Cloud Data Connector doc conflict on requirement for sub-level plans #9426

deggis opened this issue Nov 20, 2023 · 11 comments · Fixed by #9651
Assignees
Labels
Connector Connector specialty review needed

Comments

@deggis
Copy link
Contributor

deggis commented Nov 20, 2023

Describe the bug
Documentation for Defender for Cloud Data connector has conflicting statements and does not cover subscriptions with only per-resource enabled Defender for Cloud plans.

To Reproduce
Steps to reproduce the behavior:

  1. Go to see documentation for Defender for Cloud data connector:

There seems to be inconsistency between the lines 58 and 69:

  • "standard tier is no longer required. The connector is available for all deployments of Microsoft Defender for Cloud"
  • "The connector can be enabled only on subscriptions that have at least one Microsoft Defender plan enabled in Microsoft Defender for Cloud"

Expected behavior

  • "standard tier is no longer required" this comment seems obsolete and seems to refer to an era where there as a single pricing tier for Defender for Cloud.
  • "standard tier is no longer required" vs "that have at least one Microsoft Defender plan enabled in Microsoft Defender for Cloud" which one is it?

If this text stays, "that have at least one Microsoft Defender plan enabled in Microsoft Defender for Cloud", I would expect the documentation to updated to cover subscriptions that don't have per sub plans, but only per resource enablements (like Defender for Storage) for some resources.

Copy link
Contributor

Thank you for submitting an Issue to the Azure Sentinel GitHub repo! You should expect an initial response to your Issue from the team within 5 business days. Note that this response may be delayed during holiday periods. For urgent, production-affecting issues please raise a support ticket via the Azure Portal.

@v-muuppugund
Copy link
Contributor

Hi @deggis , Thanks for flagging this issue, we will investigate this issue and get back to you with some updates by 24Nov23. Thanks!

@v-muuppugund v-muuppugund self-assigned this Nov 21, 2023
@v-amolpatil v-amolpatil added the Connector Connector specialty review needed label Nov 21, 2023
@v-muuppugund
Copy link
Contributor

Hi @deggis ,I am working on changes and will get back to you with updates by 29Nov23.

@v-muuppugund
Copy link
Contributor

v-muuppugund commented Dec 15, 2023

Hi @deggis ,Apologies for the delayed response, Standard tier one has been removed ,but as per the connector configuration we need to select subscriptions where Microsoft defender plans are enabled, Please let me know if its 5n, I am proceeding with the changes and will have an internal review(https://github.com/Azure/Azure-Sentinel/tree/users/v-muuppugund/CloudDataConnector).

@v-muuppugund
Copy link
Contributor

Hi @deggis ,Gentle Reminder, Please let me know if you have issues on above mentioned changes, otherwise will proceed with changes, Thanks.

@deggis
Copy link
Contributor Author

deggis commented Dec 18, 2023

At least the removal of "standard tier is no longer required." looks good to me.

@v-muuppugund
Copy link
Contributor

v-muuppugund commented Dec 21, 2023

@deggis ,sure,already done it,working on internal review of PR (#9651)

@v-muuppugund
Copy link
Contributor

@deggis ,Will update you once PR completed,Thanks.

@v-muuppugund
Copy link
Contributor

v-muuppugund commented Jan 12, 2024

@deggis ,Its a 1p connector and don't have permissions, Will update you, Thanks.

@v-sudkharat v-sudkharat linked a pull request Jan 18, 2024 that will close this issue
@v-muuppugund
Copy link
Contributor

Hi @deggis ,Pushing the PR as we have the process for 1p connector and will keep you updated once pr is completed

@v-sudkharat
Copy link
Contributor

Hey @deggis, PR has been merged, and the new changes will get reflect in upcoming solution version. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants