-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users/v muuppugund/cloud data connector #9651
Conversation
…ging for any major change
Hi @v-muuppugund, thank you for raising PR by adding changes, as discussed please add testing completed screenshot in PR itself. Thanks! |
@v-muuppugund, 1- Please update the release notes path in create ui file - 2- Description for both the connector looks same, please check on it -
I have checked the data file and found that this connector is 1P - true - Please check on this. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks Good.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
-3.0.1
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.